Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up genesis config presets for all runtimes #450

Merged

Conversation

seadanda
Copy link
Contributor

@seadanda seadanda commented Aug 30, 2024

This PR does three things related to chain-specs and genesis config presets:

  • Refactor preset_names to genesis_config_presets in all runtimes as suggested for the Polkadot Coretime runtime in Add the Polkadot Coretime runtime #410.
  • Make the chain-spec generator use the preset from the WASM directly for each runtime.
  • Propagate the on_chain_release_build feature to the chain-spec generator. Without this we cannot generate live/genesis chain-specs with the chain-spec generator without having to post-process it to replace the WASM compiled with this flag.

@seadanda seadanda marked this pull request as ready for review August 30, 2024 14:15
@bkchr
Copy link
Contributor

bkchr commented Sep 1, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) September 1, 2024 20:28
@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

auto-merge was automatically disabled September 6, 2024 08:04

Head branch was pushed to by a user without write access

@seadanda
Copy link
Contributor Author

seadanda commented Sep 6, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) September 6, 2024 10:34
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot merged commit 24bd45f into polkadot-fellows:main Sep 6, 2024
40 of 47 checks passed
@kianenigma
Copy link
Contributor

Why does the fellowship repo have this chain-spec generator and not use OG chain-spec-builder?

Sorry of this is duplicate, I think I have heard an explanation of this recently, but I can't recall it.

@bkchr
Copy link
Contributor

bkchr commented Sep 7, 2024

Why does the fellowship repo have this chain-spec generator and not use OG chain-spec-builder?

Historical reasons. We don't really need it anymore. Someone just needs to remove it.

@bkontur
Copy link
Contributor

bkontur commented Sep 7, 2024

Why does the fellowship repo have this chain-spec generator and not use OG chain-spec-builder?

Sorry of this is duplicate, I think I have heard an explanation of this recently, but I can't recall it.

Historical reasons. We don't really need it anymore. Someone just needs to remove it.

@bkchr @kianenigma #395

@seadanda seadanda deleted the donal-chainspecs branch September 9, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants