-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowbridge Headers on Demand #365
Snowbridge Headers on Demand #365
Conversation
@acatangiu the CI wants me to update the AH Kusama spec version: https://github.com/polkadot-fellows/runtimes/actions/runs/9713954965/job/26811939881?pr=365 Not sure why because I didn't change anything in AH. The Snowbridge crates AH depends on was also not bumped. Should the BH spec version be |
spec_version: 1_002_006, | ||
spec_version: 1_002_008, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we massage the dependency bumps a bit we might get away without having to bump the AH spec versions, right @claravanstaden ?
I wouldn't release new AH runtime versions that bring nothing new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually no, I'm wrong.
Even if this PR does not change anything for AHs, there have been other things merged in the meantime relevant to AHs.
So all good with bumping this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acatangiu thanks! I see CI is complaining about the Kusama relay version too: https://github.com/polkadot-fellows/runtimes/actions/runs/9740656775/job/26878232348?pr=365
I bumped both the Polkadot and Kusama relay versions: b2a0b26
Is that OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, all good 👍 we have changelog entries for them too I see
@acatangiu I removed the P<>K and Snowbridge unstuck migrations, since they ran successfully. Is that OK? |
@acatangiu what is the process to update the benchmarks? I need to do that before we release. Can I run it manually? |
Actually, there is no process yet :), but there is some ongoing work on the bot or process #128 by @mordamax. You can do it by yourself, here is a tutorial: https://github.com/polkadot-fellows/runtimes/blob/main/docs/weight-generation.md and you need just some machine/VM aligned with reference hardware. I did the last couple of weights regeneration on my dedicated machine, so I can also do it for you here, just let me know which pallets do you need and I can create PR to this PR. |
@bkontur thank you for the tips! I would appreciate you helping out since I don't have the required hardware ready off-hand. I need new weights for these two pallets:
Thanks again! <3 |
please, check: Snowfork#13 |
Review required! Latest push from author must always be reviewed |
1 similar comment
Review required! Latest push from author must always be reviewed |
/merge |
78c4600
into
polkadot-fellows:main
Enabled Available commands
For more information see the documentation |
Upgrades Snowbridge to have a much more cost effective Ethereum light client. In the current light client in production, all Ethereum execution headers are stored, whether they contain a transfer message or not. This PR upgrades Snowbridge to not store execution headers at all, but provide the execution header proof alongside a message. Ethereum beacon headers are still stored, to track finalized headers and do ancestry proofs.
More details on the change on the original PR: paritytech/polkadot-sdk#3761