Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrations to onboard people immediately and tidy up previous intervention #286

Merged

Conversation

seadanda
Copy link
Contributor

@seadanda seadanda commented Apr 24, 2024

When calling the reserve extrinsic after sales have started, the assignment will be reserved, but two sale period boundaries must pass before the core is actually assigned.

Since this can take between 28 and 56 days on production networks, a new extrinsic is introduced to shorten the timeline at the "cost" of more weight in paritytech/polkadot-sdk#4273.

This essentially performs four actions:

  1. Add an additional core for the new reservation
  2. Reserve it (applies after two sale boundaries)
  3. Add it to the Workplan for the next sale period
  4. Add it to the Workplan for the rest of the current sale period

To allow a quick People Chain onboarding on Kusama, a migration is introduced here which does the same thing without needing to wait for a release and to upgrade the runtimes repo.

Another migration is added to clean up an outdated assignment in state from the old sale start before the leases were added. This avoids the first lease (parachain 2000) losing its core to the new pool core a few days before it is given one again with the new timeline at the end of the new sale period 0.

@joepetrowski joepetrowski mentioned this pull request Apr 25, 2024
10 tasks
@seadanda
Copy link
Contributor Author

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 374e092 into polkadot-fellows:main Apr 29, 2024
42 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@seadanda seadanda deleted the donal-onboard-people-now branch April 29, 2024 13:57
seadanda added a commit to seadanda/runtimes that referenced this pull request Apr 29, 2024
…ervention (polkadot-fellows#286)

When calling the reserve extrinsic after sales have started, the
assignment will be reserved, but two sale period boundaries must pass
before the core is actually assigned.

Since this can take between 28 and 56 days on production networks, a new
extrinsic is introduced to shorten the timeline at the "cost" of more
weight in paritytech/polkadot-sdk#4273.

This essentially performs four actions:
1. Add an additional core for the new reservation
2. Reserve it (applies after two sale boundaries)
3. Add it to the Workplan for the next sale period
4. Add it to the Workplan for the rest of the current sale period

To allow a quick People Chain onboarding on Kusama, a migration is
introduced here which does the same thing without needing to wait for a
release and to upgrade the runtimes repo.

Another migration is added to clean up an outdated assignment in state
from the old sale start before the leases were added. This avoids the
first lease (parachain 2000) losing its core to the new pool core a few
days before it is given one again with the new timeline at the end of
the new sale period 0.

---------

Co-authored-by: joe petrowski <[email protected]>
@seadanda seadanda mentioned this pull request Apr 29, 2024
1 task
fellowship-merge-bot bot pushed a commit that referenced this pull request Apr 29, 2024
Cherry pick #286 onto the 1.2.2 release for a clean 1.2.3 release.

This release is the one proposed in
#288

The changelog from main is clipped to only include the relevant changes
from the cherry picked commit.
- A migration is added to onboard the people chain without the usual two
sale boundary delay that came with the shift to coretime.
- Another migration is added to clean up an outdated assignment in state
from the old sale start before the leases were added.

More info in the changelog of this PR and PR #286.

- [ ] Does not require a CHANGELOG entry

---------

Co-authored-by: joe petrowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants