-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vesting to Asset Hubs #269
Add Vesting to Asset Hubs #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Why will anyone else other than W3F want to perform vested transfer of DOT? When people requesting vesting, presumably they want to vest transfer assets in pallet-assets, not the relaychain token. |
For one, the person who requested this was from Talisman, not W3F, for DOT. Two, it would be great if Parity and W3F used Asset Hub instead of the Relay Chain for vested DOT transfers. Three, yes I understand the demand for vested transfers of assets. This PR does not prevent that. |
I agree we also need vesting for pallet-assets instances too, not just pallet-balances. example community request: paritytech/polkadot-sdk#4090 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add vesting to pallet-assets instances too
That is the plan, but the Vesting pallet requires something with
I don't think we should block the feature of vesting DOT on waiting for these. Asset vesting will probably be another instance of the Vesting pallet anyway, so they have no overlap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding vesting in two steps: this PR pallet-balances, future PR pallet-assets is fine
/merge |
31ba262
into
polkadot-fellows:main
Enabled Available commands
For more information see the documentation |
Adds the Vesting pallet to the Asset Hub runtimes, as a few people have requested this feature, and in general the Asset Hubs should provide more balances/asset-related features than the Relay Chain.