-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[async_backing] Bump ParachainHost to api version 10 on polkadot #222
Merged
fellowship-merge-bot
merged 7 commits into
polkadot-fellows:main
from
alexggh:alexaggh/enable_async_backing_polkadot
Mar 13, 2024
Merged
[async_backing] Bump ParachainHost to api version 10 on polkadot #222
fellowship-merge-bot
merged 7 commits into
polkadot-fellows:main
from
alexggh:alexaggh/enable_async_backing_polkadot
Mar 13, 2024
Commits on Mar 7, 2024
-
Bump ParachainHost to api version 7 on polkadot
This will enable async-backing subsystems on polkadot, the relaychain would work in legacy mode where only candiddates built on top of pervious relay chain are activated. - Had to bring an unrelated change as well `minimum_backing_votes` because that was the v6, we can't skip versions, the value of that configuration on polkadot is 2, so that's what is going to be used after this runtime update. Changes have been running on kusama, so I would. Async backing subsytems is a major change in the way collator-protocol and the backing work, so there are still some unknowns if this is completely bug free. It has been running on kusama for a month already, but not without issues: - Validators that did not upgrade to compatible versions will not be able to participate in backing, so if enough of those are randomly picked that group won't be able to back anything. With backing_group_size = 5 and minimum_backing_votes = 2, 10% validator not upgraded that chance is about 2.5%. - Additionally, same un-upgraded groups won't be able to include the backing votes on chain when they author blocks, so 10% of the blocks won't back any candidates. - We are still not sure if item 2) from here paritytech/polkadot-sdk#3314 (comment) is caused by async backing, the observable issue is sometimes after restart/upgrade some validators are getting 0 rewards and apparently they are not backing anything. Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f7ab191 - Browse repository at this point
Copy the full SHA f7ab191View commit details
Commits on Mar 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2b48404 - Browse repository at this point
Copy the full SHA 2b48404View commit details
Commits on Mar 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b49c804 - Browse repository at this point
Copy the full SHA b49c804View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06719cd - Browse repository at this point
Copy the full SHA 06719cdView commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 169d614 - Browse repository at this point
Copy the full SHA 169d614View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4fe4fe8 - Browse repository at this point
Copy the full SHA 4fe4fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a50e62 - Browse repository at this point
Copy the full SHA 6a50e62View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.