Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParentOrSiblings #102

Conversation

franciscoaguirre
Copy link
Contributor

We were accepting all type of sibling, not only sibling parachains.

@xlc
Copy link
Contributor

xlc commented Nov 23, 2023

I am not going to block this PR but how do we know if this is doing the right thing? and we definitely need regression test somewhere. I won't require it to happen in this PR / this repo but someone have to make sure it happens.

@muharem
Copy link
Contributor

muharem commented Nov 30, 2023

I am not going to block this PR but how do we know if this is doing the right thing? and we definitely need regression test somewhere. I won't require it to happen in this PR / this repo but someone have to make sure it happens.

we have some tests with xcm-emulator in CI pipeline here paritytech/polkadot-sdk#2566
and we have e2e tests which actually includes asserts for the xcm version updates via subscription (ParentOrSiblings type involved there), we should run them for RC. not yet ideal, but we have some and should continues to add more cases there.

@muharem muharem mentioned this pull request Feb 2, 2024
19 tasks
@bkontur
Copy link
Contributor

bkontur commented Feb 16, 2024

I would suggest to close this PR, because this will be fixed also here: 44eefcc as a part of 1.6.0 bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants