-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ParentOrSiblings #102
Fix ParentOrSiblings #102
Conversation
I am not going to block this PR but how do we know if this is doing the right thing? and we definitely need regression test somewhere. I won't require it to happen in this PR / this repo but someone have to make sure it happens. |
we have some tests with xcm-emulator in CI pipeline here paritytech/polkadot-sdk#2566 |
I would suggest to close this PR, because this will be fixed also here: 44eefcc as a part of 1.6.0 bump |
We were accepting all type of sibling, not only sibling parachains.