Use runtime api for getting base fee #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Nov 28, 2022
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the dependency between the storage overrides and
pallet-base-fee, as Frontier projects might not use the pallet, getting wrong base fee values. Uses the runtime-apigas_priceinstead.Note
In general, runtime api access is always affected by the
max_runtime_instancesconfiguration used: the more number of runtime instances allowed to keep in memory, the lower the chance of having to recompile aVersionedRuntimeon the fly and thus lower CPU usage (and fastest rpc responses in this case). In any case any production node should set this cli configuration to a high value to improve performance on runtime api access across runtime versions.