-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow larger gas limit in non-transactional execution #799
Allow larger gas limit in non-transactional execution #799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm aside from the suggestion. Also, can you please add tests for it?
Changing the limit for estimateGas changes the estimation. Do we want to avoid that? Also, while I can see the point of having for exemple 10x for eth_call (perform calculations that is meant to be done off-chain), I don't see the point of estimating more than the block gas limit since you're mainly estimating to make a transaction with it. What do you think @tgmichel @albertov19 @sorpaas ? Should it be only increased for eth_call ? |
I've tried both Alchemy and Infura API (I think both run GETH Clients) and they accept 50M gas units for |
Moreover, |
* move non-transactional executation gas limit check in client * Fix condition Co-authored-by: tgmichel <[email protected]> * typo * tests * prettier * do contract call * update estimated gas in tests Co-authored-by: tgmichel <[email protected]>
Infura allows to use eth_call/eth_estimateGas with up to 10x the block gas limit:
https://docs.infura.io/infura/networks/ethereum/json-rpc-methods/eth_call
To replicate this feature :