-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eth_getBlockReceipts
#1156
Add eth_getBlockReceipts
#1156
Conversation
Hey, I agree that this method can be really useful! (eg But I'm not sure about how we are implementing it:
This looks expensive, as this is adding an expensive overhead to the process. I'd like to suggest 2 approaches here: 1 - Using this storage override (cheers to @tgmichel for pointing it out while ago): 2 - Move logic (after instantiating phase) from I'll provide a performance comparison (between your approach and |
Nice suggestions! Let's update this today. |
@boundless-forest @arturgontijo hey guys, just to let you know I am currently taking a break as I recently left Moonbeam, so I will not be able to review for a while. I will be back at some point :) |
😱 I'm quite amazed it doesn't seem to need any EIP process any more! |
See the discussion at ethereum/execution-apis#438. This RPC is quite helpful for explorers.
@sorpaas @tgmichel Please take a review.