Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Template Release Script not working #1082

Closed
cdxker opened this issue Jun 20, 2023 · 3 comments · Fixed by #1327
Closed

Node Template Release Script not working #1082

cdxker opened this issue Jun 20, 2023 · 3 comments · Fixed by #1327
Labels
bug Something isn't working

Comments

@cdxker
Copy link

cdxker commented Jun 20, 2023

Description

When running .maintain/node-template-release.sh archive.tar.gz I get this response

    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
warning: the following packages contain code that will be rejected by a future version of Rust: fs_extra v1.2.0
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`
     Running `target/debug/node-template-release /home/fastfist/work/frontier/template /home/fastfist/work/frontier/archive.tar.gz`
error: failed to load manifest for workspace member `/tmp/.tmpV7eHJG/template/node`

Caused by:
  failed to parse manifest at `/tmp/.tmpV7eHJG/template/node/Cargo.toml`

Caused by:
  error inheriting `edition` from workspace root manifest's `workspace.package.edition`

Caused by:
  `workspace.package.edition` was not defined
thread 'main' panicked at 'assertion failed: Command::new(\"cargo\").args(&[\"build\",\n                                \"--all\"]).current_dir(path).status().expect(\"Compiles node\").success()', src/main.rs:188:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Environment

  • Operating system: Ubuntu 22.04.2 LTS x86_6 and Manjaro Linux
  • Project version/tag: master and bar/polkadot-v0.9.4
  • Rust version (run rustup show):
$ rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /home/fastfist/.rustup

installed toolchains
--------------------

stable-x86_64-unknown-linux-gnu
nightly-2023-01-01-x86_64-unknown-linux-gnu
nightly-2023-05-22-x86_64-unknown-linux-gnu (default)
nightly-x86_64-unknown-linux-gnu
1.68.2-x86_64-unknown-linux-gnu

active toolchain
----------------

nightly-2023-05-22-x86_64-unknown-linux-gnu (default)
rustc 1.71.0-nightly (9d871b061 2023-05-21)
@cdxker cdxker added the bug Something isn't working label Jun 20, 2023
@farazahmadvaival
Copy link

i am also getting this error. Please share the solution.

@lucgerrits
Copy link

lucgerrits commented Nov 6, 2023

Same for me.
EDIT: I'm on branch polkadot-v1.1.0

lucgerrits added a commit to lucgerrits/frontier that referenced this issue Nov 20, 2023
@lucgerrits
Copy link

Forked and propose this fix: lucgerrits@44be8ed

But as you will discover, compiling fails:

...
...
error: no rules expected the token `frame_support`
     --> /tmp/.tmp9ZpRHL/template/runtime/src/lib.rs:402:1
      |
  402 | / construct_runtime!(
  403 | |     pub enum Runtime {
  404 | |         System: frame_system,
  405 | |         Timestamp: pallet_timestamp,
  ...   |
  417 | |     }
  418 | | );
      | |_^ no rules expected this token in macro call
      |
  note: while trying to match `your_tt_return`
     --> /home/lgerrits/.cargo/git/checkouts/frontier-b4643f17507d3282/176cb34/frame/hotfix-sufficients/src/lib.rs:39:1
      |
  39  | #[frame_support::pallet]
      | ^^^^^^^^^^^^^^^^^^^^^^^^
      = note: captured metavariables except for `:tt`, `:ident` and `:lifetime` cannot be compared to other tokens
      = note: see <https://doc.rust-lang.org/nightly/reference/macros-by-example.html#forwarding-a-matched-fragment> for more information
      = note: this error originates in the macro `frame_support::__private::tt_call` which comes from the expansion of the attribute macro `frame_support::pallet` (in Nightly builds, run with -Z macro-backtrace for more info)

  error[E0412]: cannot find type `Aura` in this scope
     --> /tmp/.tmp9ZpRHL/template/runtime/src/lib.rs:110:14
      |
  110 |             pub aura: Aura,
      |                       ^^^^ not found in this scope

  error[E0412]: cannot find type `Grandpa` in this scope
     --> /tmp/.tmp9ZpRHL/template/runtime/src/lib.rs:111:17
      |
  111 |             pub grandpa: Grandpa,
      |                          ^^^^^^^ help: a type alias with a similar name exists: `GrandpaId`
      |
     ::: /home/lgerrits/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/c8d2251/substrate/primitives/consensus/grandpa/src/lib.rs:57:1
      |
  57  | pub type AuthorityId = app::Public;
      | -------------------- similarly named type alias `GrandpaId` defined here

  error[E0412]: cannot find type `Aura` in this scope
     --> /tmp/.tmp9ZpRHL/template/runtime/src/lib.rs:110:14
      |
  110 |             pub aura: Aura,
      |                       ^^^^ not found in this scope
      |
  help: you might be missing a type parameter
     --> /home/lgerrits/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/c8d2251/substrate/primitives/runtime/src/traits.rs:1997:19
      |
  1997|         pub struct $name<Aura> {
      |                         ++++++
...
...
...
(Many more errors)

@boundless-forest boundless-forest linked a pull request Mar 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants