Handling External Links for MDX globally #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imadarai
requested review from
jimmychu0807,
sacha-l,
nuke-web3 and
lsgunnlsgunn
|
✔️ Deploy Preview for substrate-docs-staging ready! 🔨 Explore the source changes: 0d9cf5c 🔍 Inspect the deploy log: https://app.netlify.com/sites/substrate-docs-staging/deploys/615ee8fa569b18000857625d 😎 Browse the preview: https://deploy-preview-223--substrate-docs-staging.netlify.app |
|
Update: seems it was a 👻 - all working as expected now on master (after #250 landed) |
This was referenced Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address external links opening in a new window and displaying an Icon next to it. This is addressed globally for all MDX files, so we don't need to go in and change each MDX file individually.
The current
ExternalLinkcomponents can be left as is or replaced with Markdown syntax.If there are any strong opinions about #3 , I can introduce changes in this PR.
As it stands right now:
httpswill open in a new tab/rustdocs/will open in new tabrest will remain locally (including hash tags).
As this is a global change, I need to scan some more documents to make sure its not introducing any bugs or edge cases.
Will merge this tomorrow if everyone is on board 😄