Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients/modal: add animation to modals #4521

Merged
merged 3 commits into from
Nov 22, 2024
Merged

clients/modal: add animation to modals #4521

merged 3 commits into from
Nov 22, 2024

Conversation

emilwidlund
Copy link
Member

No description provided.

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar 🛑 Canceled (Inspect) Nov 23, 2024 2:05am
polar-sandbox ❌ Failed (Inspect) Nov 23, 2024 2:05am

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 154.28 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/layout 108.05 KB 262.34 KB 74.95% (🟡 +0.01%)
/(main)/(topbar)/layout 250.74 KB 405.03 KB 115.72% (+/- <0.01%)
/(main)/[organization]/(header)/issues/page 133.67 KB 287.95 KB 82.27% (+/- <0.01%)
/(main)/[organization]/(header)/layout 280.47 KB 434.75 KB 124.21% (+/- <0.01%)
/(main)/[organization]/(header)/page 147.26 KB 301.55 KB 86.16% (+/- <0.01%)
/(main)/[organization]/(header)/portal/page 103.9 KB 258.19 KB 73.77% (+/- <0.01%)
/(main)/[organization]/(header)/posts/page 191.55 KB 345.84 KB 98.81% (+/- <0.01%)
/(main)/[organization]/(header)/posts/[postSlug]/page 236.84 KB 391.12 KB 111.75% (+/- <0.01%)
/(main)/[organization]/[repo]/issues/[number]/(create)/page 204.7 KB 358.99 KB 102.57% (🟡 +0.02%)
/(main)/[organization]/[repo]/layout 243.27 KB 397.55 KB 113.59% (+/- <0.01%)
/(main)/[organization]/[repo]/issues/[number]/status/page 233.62 KB 387.9 KB 110.83% (+/- <0.01%)
/(main)/backoffice/badge/page 54.88 KB 209.16 KB 59.76% (+/- <0.01%)
/(main)/[organization]/[repo]/page 209.13 KB 363.41 KB 103.83% (+/- <0.01%)
/(main)/backoffice/pledges/page 66.93 KB 221.21 KB 63.20% (+/- <0.01%)
/(main)/backoffice/rewards_pending/page 68.69 KB 222.97 KB 63.71% (🟢 -0.01%)
/(main)/backoffice/issue/[id]/page 64.67 KB 218.95 KB 62.56% (+/- <0.01%)
/(main)/docs/api/[...endpoint]/page 514.89 KB 669.17 KB 191.19% (+/- <0.01%)
/(main)/docs/layout 240.93 KB 395.21 KB 112.92% (+/- <0.01%)
/(main)/(landing)/page 496.65 KB 650.93 KB 185.98% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/products/[id]/page 264.44 KB 418.72 KB 119.64% (🟡 +0.24%)
/(main)/(topbar)/(backer)/purchases/products/page 98.75 KB 253.03 KB 72.29% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/subscriptions/page 98.31 KB 252.6 KB 72.17% (+/- <0.01%)
/(main)/(topbar)/(backer)/settings/page 277.42 KB 431.7 KB 123.34% (🟡 +0.54%)
/(main)/(topbar)/(backer)/purchases/subscriptions/[id]/page 267.47 KB 421.75 KB 120.50% (🟡 +0.24%)
/(main)/dashboard/(create)/create/page 157.38 KB 311.66 KB 89.05% (+/- <0.01%)
/(main)/dashboard/[organization]/storefront/page 355.79 KB 510.08 KB 145.74% (+/- <0.01%)
/(main)/dashboard/[organization]/layout 57.34 KB 211.62 KB 60.46% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/better-pricing/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/(landing)/(mdx)/legal/privacy/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/(mdx)/layout 458.02 KB 612.3 KB 174.94% (+/- <0.01%)
/(main)/docs/(mdx)/fees/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/(mdx)/finance/payouts/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/(mdx)/github/funding-yaml/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/(mdx)/merchant-of-record/tax/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/(mdx)/merchant-of-record/compliance/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/(mdx)/payments-taxes/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/api/(mdx)/authentication/page 237.57 KB 391.85 KB 111.96% (🟡 +0.54%)
/(main)/docs/api/(mdx)/layout 458.01 KB 612.29 KB 174.94% (+/- <0.01%)
/(main)/docs/developers/(mdx)/layout 458.01 KB 612.3 KB 174.94% (+/- <0.01%)
/(main)/docs/developers/guides/layout 458.02 KB 612.3 KB 174.94% (+/- <0.01%)
/(main)/docs/developers/guides/node/page 33.43 KB 187.71 KB 53.63% (+/- <0.01%)
/(main)/docs/developers/sandbox/layout 458.02 KB 612.3 KB 174.94% (+/- <0.01%)
/(main)/docs/developers/open-source/page 33.43 KB 187.71 KB 53.63% (+/- <0.01%)
/(main)/docs/developers/open-source/layout 458.02 KB 612.3 KB 174.94% (+/- <0.01%)
/(main)/docs/developers/sdk/github-actions/page 33.43 KB 187.71 KB 53.63% (+/- <0.01%)
/(main)/docs/developers/sdk/layout 458.01 KB 612.29 KB 174.94% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-init/page 33.43 KB 187.71 KB 53.63% (+/- <0.01%)
/(main)/docs/developers/sdk/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/developers/sdk/typescript/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/support/layout 458.01 KB 612.29 KB 174.94% (+/- <0.01%)
/(main)/docs/support/(mdx)/page 31.01 KB 185.29 KB 52.94% (+/- <0.01%)
/(main)/docs/developers/webhooks/layout 458.2 KB 612.48 KB 174.99% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/account/page 208.87 KB 363.16 KB 103.76% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/layout 221.26 KB 375.55 KB 107.30% (+/- <0.01%)
/(main)/(topbar)/(backer)/(sidebar)/funding/page 257.19 KB 411.47 KB 117.56% (+/- <0.01%)
/(main)/(topbar)/(backer)/(sidebar)/layout 140.1 KB 294.39 KB 84.11% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/incoming/page 241.37 KB 395.65 KB 113.04% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/outgoing/page 190.94 KB 345.22 KB 98.64% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/rewards/page 121.37 KB 275.65 KB 78.76% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/(home)/page 657.53 KB 811.82 KB 231.95% (🟡 +0.55%)
/(main)/dashboard/[organization]/(header)/benefits/license-keys/page 599.9 KB 754.18 KB 215.48% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/benefits/page 652.49 KB 806.77 KB 230.51% (🟡 +0.52%)
/(main)/dashboard/[organization]/(header)/initialize/page 150.91 KB 305.2 KB 87.20% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/benefits/page 652.03 KB 806.31 KB 230.37% (🟡 +0.52%)
/(main)/dashboard/[organization]/(header)/products/[id]/page 649.08 KB 803.37 KB 229.53% (🟡 +0.09%)
/(main)/dashboard/[organization]/(header)/products/page 595.05 KB 749.33 KB 214.10% (🟡 +0.45%)
/(main)/dashboard/[organization]/(header)/products/discounts/page 631.08 KB 785.37 KB 224.39% (🟡 +0.45%)
/(main)/dashboard/[organization]/(header)/sales/subscriptions/page 605.81 KB 760.09 KB 217.17% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/new/page 641.04 KB 795.32 KB 227.24% (🟡 +0.06%)
/(main)/dashboard/[organization]/(header)/settings/custom-fields/page 605.08 KB 759.36 KB 216.96% (🟡 +0.42%)
/(main)/dashboard/[organization]/(header)/sales/page 622.19 KB 776.47 KB 221.85% (🟡 +2.30%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/page 586.19 KB 740.47 KB 211.56% (🟡 +0.43%)
/(main)/dashboard/[organization]/(white)/posts/[post]/page 659.68 KB 813.96 KB 232.56% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/endpoints/[id]/page 603.63 KB 757.91 KB 216.55% (🟡 +0.41%)
/(main)/dashboard/[organization]/(header)/finance/account/page 162.76 KB 317.04 KB 90.58% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/incoming/page 195.12 KB 349.4 KB 99.83% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/outgoing/page 144.65 KB 298.94 KB 85.41% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/contributors/page 74.95 KB 229.23 KB 65.50% (🟢 -0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/rewarded/page 74.95 KB 229.23 KB 65.49% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/page 75.66 KB 229.95 KB 65.70% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@emilwidlund emilwidlund merged commit 4a61bcd into main Nov 22, 2024
11 of 15 checks passed
@emilwidlund emilwidlund deleted the inline-model branch November 22, 2024 20:47
@vercel vercel bot temporarily deployed to Preview – polar November 22, 2024 21:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant