Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escaped sql scripts make database deadlock #954

Merged
merged 9 commits into from
Feb 27, 2023
Merged

fix: escaped sql scripts make database deadlock #954

merged 9 commits into from
Feb 27, 2023

Conversation

andrewshan
Copy link
Member

@andrewshan andrewshan commented Feb 25, 2023

Please provide issue(s) of this PR:
Fixes #953

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Feb 25, 2023

2023-02-25 18:10:58: =========TEST START==========
2023-02-25 18:11:24: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-02-26 17:12:30: =========TEST START==========
2023-02-26 17:12:55: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-02-26 21:31:50: =========TEST START==========
2023-02-26 21:32:15: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-02-27 10:27:17: =========TEST START==========
2023-02-27 10:27:42: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-02-27 11:14:20: =========TEST START==========
2023-02-27 11:14:44: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-02-27 13:26:47: =========TEST START==========
2023-02-27 13:27:13: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2023-02-27 13:39:48: [STANDALONE VERSION]PR autotest FAILED! We executed 0 test cases and 0 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1254158930/sta/qta-report.html
2023-02-27 13:39:52: [CLUSTER VERSION] PR autotest FAILED! We executed 0 test cases and 0 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1254158930/clu/qta-report.html
2023-02-27 13:39:55: [KUBENETES VERSION]PR autotest FAILED! We executed 0 test cases and 0 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1254158930/k8s/qta-report.html

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #954 (5134952) into main (dbfbea8) will decrease coverage by 0.13%.
The diff coverage is 26.26%.

❗ Current head 5134952 differs from pull request most recent head f4b6e8a. Consider uploading reports for the commit f4b6e8a to get more accurate results

@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   57.41%   57.28%   -0.13%     
==========================================
  Files         185      185              
  Lines       33638    33778     +140     
==========================================
+ Hits        19312    19351      +39     
- Misses      11810    11886      +76     
- Partials     2516     2541      +25     
Impacted Files Coverage Δ
store/mysql/client.go 35.67% <0.00%> (ø)
store/mysql/maintain.go 51.09% <6.15%> (-4.25%) ⬇️
store/mysql/routing_config.go 41.37% <13.33%> (-2.91%) ⬇️
store/mysql/group.go 53.73% <20.00%> (ø)
store/mysql/l5.go 8.48% <20.00%> (ø)
store/mysql/circuitbreaker_config.go 47.27% <27.52%> (-2.73%) ⬇️
store/mysql/instance.go 52.73% <29.47%> (-1.18%) ⬇️
store/mysql/service.go 49.73% <32.14%> (-0.32%) ⬇️
store/mysql/namespace.go 50.76% <39.53%> (-5.12%) ⬇️
store/mysql/ratelimit_config.go 59.35% <75.00%> (+1.00%) ⬆️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

store/mysql/group.go Outdated Show resolved Hide resolved
store/mysql/client.go Outdated Show resolved Hide resolved
@andrewshan andrewshan merged commit 9c1bfc6 into polarismesh:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL deadlock make cache update suspend for long time
4 participants