Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #822] self health check by leader instance #832

Merged
merged 9 commits into from
Dec 6, 2022

Conversation

shichaoyuan
Copy link
Member

Please provide issue(s) of this PR:
Fixes #822

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Nov 30, 2022

2022-11-30 23:00:34: =========TEST START==========
2022-11-30 23:01:00: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2022-11-30 23:12:37: [STANDALONE VERSION]PR autotest FAILED! We executed 14 test cases and 13 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/sta/qta-report.html
2022-11-30 23:12:41: [CLUSTER VERSION] PR autotest FAILED! We executed 14 test cases and 13 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/clu/qta-report.html
2022-11-30 23:12:44: [KUBENETES VERSION]PR autotest FAILED! We executed 14 test cases and 13 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/k8s/qta-report.html
2022-11-30 23:17:08: =========TEST START==========
2022-11-30 23:17:33: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2022-11-30 23:29:34: [STANDALONE VERSION]PR autotest FAILED! We executed 14 test cases and 13 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/sta/qta-report.html
2022-11-30 23:29:38: [CLUSTER VERSION] PR autotest FAILED! We executed 14 test cases and 13 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/clu/qta-report.html
2022-11-30 23:29:42: [KUBENETES VERSION]PR autotest FAILED! We executed 14 test cases and 13 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/k8s/qta-report.html
2022-12-02 23:35:12: =========TEST START==========
2022-12-02 23:35:49: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2022-12-02 23:46:55: [STANDALONE VERSION]PR autotest PASSED! We executed 14 test cases and 14 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/sta/qta-report.html
2022-12-02 23:46:59: [CLUSTER VERSION] PR autotest PASSED! We executed 14 test cases and 14 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/clu/qta-report.html
2022-12-02 23:47:02: [KUBENETES VERSION]PR autotest FAILED! We executed 14 test cases and 13 were passed. You can see test report in https://polaris-opentest-1306863770.cos.ap-guangzhou.myqcloud.com/pr1140484808/k8s/qta-report.html
2022-12-04 23:09:42: =========TEST START==========
2022-12-04 23:10:09: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2022-12-04 23:16:23: =========TEST START==========
2022-12-04 23:16:49: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2022-12-05 14:00:04: =========TEST START==========
2022-12-05 14:00:36: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2022-12-05 21:19:44: =========TEST START==========
2022-12-05 21:20:11: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.
2022-12-05 23:48:28: =========TEST START==========
2022-12-05 23:48:54: Pre-Merge check success! Now we will perform a full automated test which is expected to take 2 hours, thank you for your patience.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #832 (6ec81ac) into main (1ee83ed) will increase coverage by 2.53%.
The diff coverage is 5.00%.

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   57.22%   59.76%   +2.53%     
==========================================
  Files         162      135      -27     
  Lines       29028    22068    -6960     
==========================================
- Hits        16612    13188    -3424     
+ Misses      10207     7268    -2939     
+ Partials     2209     1612     -597     
Impacted Files Coverage Δ
common/model/naming.go 70.83% <ø> (ø)
store/boltdb/maintain.go 40.90% <0.00%> (-21.16%) ⬇️
store/boltdb/service.go 55.94% <0.00%> (ø)
store/boltdb/default.go 59.32% <100.00%> (ø)
cache/service.go 83.02% <0.00%> (-0.37%) ⬇️
store/mock/maintain_mock.go
store/mysql/base_db.go
store/mysql/circuitbreaker_config.go
store/mysql/client.go
store/mysql/common.go
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bootstrap/self_checker.go Outdated Show resolved Hide resolved
bootstrap/self_checker.go Outdated Show resolved Hide resolved
@chuntaojun chuntaojun added this to the v1.14.0 milestone Dec 1, 2022
@shichaoyuan
Copy link
Member Author

@chuntaojun 先改了一版支持多leader,看一下

@chuntaojun
Copy link
Member

新增的逻辑覆盖率有点低,看看补一些测试用例吧

@chuntaojun
Copy link
Member

代码组织结构有点调整,辛苦处理下

service/healthcheck/check.go Outdated Show resolved Hide resolved
store/mysql/maintain.go Show resolved Hide resolved
store/boltdb/maintain.go Outdated Show resolved Hide resolved
@chuntaojun chuntaojun added enhancement New feature or request keystone the key feature of the milestone labels Dec 6, 2022
@chuntaojun chuntaojun merged commit 69aabd6 into polarismesh:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keystone the key feature of the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

由leader节点进行 polaris.checker 健康检查
3 participants