Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:nacos-client query service list not found and can't clean invalid client beat info #1326

Merged
merged 15 commits into from
Feb 3, 2024

Conversation

chuntaojun
Copy link
Member

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@polaris-test-bot
Copy link

polaris-test-bot commented Feb 1, 2024

2024-02-02 03:28:03: =========TEST START==========
2024-02-03 08:41:38: =========TEST START==========
2024-02-03 14:55:03: =========TEST START==========
2024-02-04 00:48:58: =========TEST START==========
2024-02-04 01:10:22: =========TEST START==========

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (ea1f4f7) 57.85% compared to head (1d37a87) 21.71%.

Files Patch % Lines
apiserver/xdsserverv3/eds.go 0.00% 62 Missing ⚠️
apiserver/xdsserverv3/server.go 0.00% 19 Missing ⚠️
apiserver/xdsserverv3/cds.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1326       +/-   ##
===========================================
- Coverage   57.85%   21.71%   -36.14%     
===========================================
  Files         186       35      -151     
  Lines       37494     5272    -32222     
===========================================
- Hits        21691     1145    -20546     
+ Misses      13205     4031     -9174     
+ Partials     2598       96     -2502     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuntaojun chuntaojun merged commit fcfec62 into polarismesh:main Feb 3, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants