Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:support partial configuration encrypt. #566

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

SkyeBeFreeman
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 37.30159% with 79 lines in your changes missing coverage. Please review.

Project coverage is 20.55%. Comparing base (eb478f6) to head (c623746).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ava/com/tencent/polaris/encrypt/EncryptConfig.java 0.00% 28 Missing ⚠️
...java/com/tencent/polaris/encrypt/util/AESUtil.java 70.68% 15 Missing and 2 partials ⚠️
...guration/client/internal/ConfigPropertiesFile.java 21.42% 10 Missing and 1 partial ⚠️
.../polaris/encrypt/ConfigEncryptProviderFactory.java 0.00% 10 Missing ⚠️
...polaris/encrypt/impl/ConfigEncryptAESProvider.java 0.00% 10 Missing ⚠️
...tencent/polaris/encrypt/ConfigEncryptProvider.java 0.00% 1 Missing ⚠️
.../java/com/tencent/polaris/encrypt/util/SHA256.java 75.00% 1 Missing ⚠️
...s/plugins/configfilefilter/service/RSAService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #566      +/-   ##
============================================
+ Coverage     20.51%   20.55%   +0.03%     
- Complexity      797      828      +31     
============================================
  Files           323      333      +10     
  Lines         12820    13136     +316     
  Branches       1632     1677      +45     
============================================
+ Hits           2630     2700      +70     
- Misses         9847    10088     +241     
- Partials        343      348       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@SkyeBeFreeman SkyeBeFreeman force-pushed the m/config-encrypt branch 6 times, most recently from c27c1a2 to af0bd37 Compare November 27, 2024 06:44
@SkyeBeFreeman SkyeBeFreeman force-pushed the m/config-encrypt branch 2 times, most recently from 7454e0b to e18d201 Compare December 3, 2024 13:52
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SkyeBeFreeman SkyeBeFreeman merged commit f25064c into polarismesh:main Dec 5, 2024
9 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the m/config-encrypt branch December 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants