refactor!: rewrite <DataFrame>$get_columns()
#991
Conversation
| let cols = self.0.get_columns().to_vec(); | ||
| let vec = unsafe { std::mem::transmute::<Vec<pl::Series>, Vec<RPolarsSeries>>(cols) }; | ||
| List::from_values(vec) |
There was a problem hiding this comment.
I don't understand this change, the original was readable and didn't have any unsafe
There was a problem hiding this comment.
This implementation is copied from Python.
What is the problem with unsafe?
There was a problem hiding this comment.
This implementation is copied from Python.
I didn't see it in get_columns() but indeed to_pyseries() has that. So I'm fine with that
What is the problem with unsafe?
I don't have a great knowledge of Rust, so I'd rather avoid unsafe since I have no idea in which context it's fine and in which it's not. Maybe there's no problem in this case, but I don't know that in advance.
There was a problem hiding this comment.
I don't think we can completely eliminate unsafe in terms of accessing the C ABI of Python or R.
(As evidenced by the fact that we sometimes crash R sessions.)
No description provided.