-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to the edge version (0.6.x) of extendr-api #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
changed the title
chore: switch to the release version of extendr-api and cargo update
chore: switch to the release version of extendr-api
Oct 29, 2023
… update [skip ci]" This reverts commit 5794206.
eitsupi
force-pushed
the
extendr-0.6.0
branch
from
October 30, 2023 11:16
d8853ab
to
a7202a2
Compare
eitsupi
force-pushed
the
extendr-0.6.0
branch
from
October 30, 2023 15:32
a7202a2
to
48e302a
Compare
I saw these errors now:
@sorhawell Sorry for bothering you, but do you know about this? |
No problem :) Try using .inner() |
eitsupi
changed the title
chore: switch to the release version of extendr-api
chore: switch to the edge version of extendr-api
Oct 31, 2023
eitsupi
changed the title
chore: switch to the edge version of extendr-api
chore: switch to the edge version (>= 0.6.0) of extendr-api
Oct 31, 2023
eitsupi
changed the title
chore: switch to the edge version (>= 0.6.0) of extendr-api
chore: switch to the edge version (0.6.x) of extendr-api
Nov 1, 2023
I think this PR, even as is brings good value and simplifies our fork. I hope this "result_list patch " will be merged in to exgtendr-api. Very nice work @eitsupi. |
I'm ok to merge this at this stage. |
sorhawell
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #418