Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to the edge version (0.6.x) of extendr-api #447

Merged
merged 10 commits into from
Nov 5, 2023
Merged

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Oct 29, 2023

Close #418

@eitsupi eitsupi changed the title chore: switch to the release version of extendr-api and cargo update chore: switch to the release version of extendr-api Oct 29, 2023
@eitsupi
Copy link
Collaborator Author

eitsupi commented Oct 30, 2023

I saw these errors now:

   error[E0616]: field `0` of struct `Rfloat` is private
     --> src/conversion_r_to_s.rs:80:35
      |
   80 |                         let x = x.0.to_bits() as i64;
      |                                   ^ private field
   
   error[E0616]: field `0` of struct `Rfloat` is private
      --> src/conversion_r_to_s.rs:102:66
       |
   102 |                     .map(|x| if x.is_na() { None } else { Some(x.0) })
       |                                                                  ^ private field
   
   error[E0616]: field `0` of struct `Rint` is private
      --> src/conversion_r_to_s.rs:142:66
       |
   142 |                     .map(|x| if x.is_na() { None } else { Some(x.0) })
       |                                                                  ^ private field
   
   error[E0616]: field `0` of struct `Rfloat` is private
      --> src/utils/mod.rs:107:32
       |
   107 |                 Ok(Some(rvalue.0))
       |                                ^ private field
       |
      ::: src/series.rs:396:28
       |
   396 |                 Float64 => apply_output!(r_iter, strict, allow_fail_eval, Doubles, Float64Chunked),
       |                            ----------------------------------------------------------------------- in this macro invocation
       |
       = note: this error originates in the macro `handle_type` which comes from the expansion of the macro `apply_output` (in Nightly builds, run with -Z macro-backtrace for more info)
   
   error[E0616]: field `0` of struct `Rint` is private
      --> src/utils/mod.rs:118:28
       |
   118 |             let val = rint.0;
       |                            ^ private field
       |
      ::: src/series.rs:397:26
       |
   397 |                 Int32 => apply_output!(r_iter, strict, allow_fail_eval, Integers, Int32Chunked),
       |                          ---------------------------------------------------------------------- in this macro invocation
       |
       = note: this error originates in the macro `handle_type` which comes from the expansion of the macro `apply_output` (in Nightly builds, run with -Z macro-backtrace for more info)

@sorhawell Sorry for bothering you, but do you know about this?

@sorhawell
Copy link
Collaborator

No problem :)

Try using .inner()

extendr/extendr#584

@eitsupi eitsupi changed the title chore: switch to the release version of extendr-api chore: switch to the edge version of extendr-api Oct 31, 2023
@eitsupi eitsupi changed the title chore: switch to the edge version of extendr-api chore: switch to the edge version (>= 0.6.0) of extendr-api Oct 31, 2023
@eitsupi eitsupi changed the title chore: switch to the edge version (>= 0.6.0) of extendr-api chore: switch to the edge version (0.6.x) of extendr-api Nov 1, 2023
@sorhawell
Copy link
Collaborator

I think this PR, even as is brings good value and simplifies our fork.

I hope this "result_list patch " will be merged in to exgtendr-api.

Very nice work @eitsupi.

@eitsupi eitsupi marked this pull request as ready for review November 3, 2023 22:17
@eitsupi
Copy link
Collaborator Author

eitsupi commented Nov 3, 2023

I'm ok to merge this at this stage.
Once extendr/extendr#652 is merged, we can change the reference.

@eitsupi eitsupi added this to the 0.10 milestone Nov 4, 2023
@eitsupi eitsupi merged commit d9d1488 into main Nov 5, 2023
31 checks passed
@eitsupi eitsupi deleted the extendr-0.6.0 branch November 5, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we install the fork version of extendr?
3 participants