-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support Rust 1.65 #280
Conversation
@eitsupi not sure whylinker cant find rpolars.a, but it does compile on 1.65.0 on my machine if |
Nice! It seems passing the MSRV check. |
changing cargo-toml from 1.66 to 1.65 now it should be more impressive :) |
Thanks, it seems passing! |
https://doc.rust-lang.org/cargo/reference/profiles.html#custom-profiles |
I believe Makevars can be configured to change profiles via environment variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be merged now.
@sorhawell Can I merge this and go ahead? |
Ohh profile changes output dir, that was what I was missing . Thanks @eitsupi , looks good! |
Fix #208