Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement $str$head() and $str$tail() #1074

Merged
merged 3 commits into from
May 5, 2024
Merged

Implement $str$head() and $str$tail() #1074

merged 3 commits into from
May 5, 2024

Conversation

etiennebacher
Copy link
Collaborator

No description provided.

eitsupi
eitsupi approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

A few minor comments.

R/expr__string.R Outdated Show resolved Hide resolved
R/expr__string.R Outdated Show resolved Hide resolved
@eitsupi
Copy link
Collaborator

eitsupi commented May 5, 2024

If you are ok with me making the above modifications please let me know as I would like to merge after making the modifications.

@etiennebacher
merge main
c0f48e2 
Merge branch 'main' into str-head-tail

# Conflicts:
#	NEWS.md
@etiennebacher
inherit docs
edc4372
@etiennebacher
Copy link
Collaborator Author

Thanks, I made the changes

@eitsupi eitsupi merged commit 1647e56 into main May 5, 2024
24 of 26 checks passed
@eitsupi eitsupi deleted the str-head-tail branch May 5, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebacher @eitsupi