Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust,python) respect original series dtype when constructing LitIter #9886

Merged
merged 5 commits into from
Jul 15, 2023
Merged

fix(rust,python) respect original series dtype when constructing LitIter #9886

merged 5 commits into from
Jul 15, 2023

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented Jul 14, 2023

closes #9856

@0xbe7a 0xbe7a requested a review from ritchie46 as a code owner July 14, 2023 17:41
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 14, 2023
@ritchie46 ritchie46 force-pushed the fix-lititer-dtype branch from 2310abf to e190941 Compare July 15, 2023 08:03
@0xbe7a
Copy link
Contributor Author

0xbe7a commented Jul 15, 2023 •
edited
Loading

Is there a reason FlatIter is still constructed with cast(...).unwrap() ?

@ritchie46
Copy link
Member

Is there a reason FlatIter is still constructed with cast(...).unwrap() ?

Nope, should do the same. Sorry that I pushed a few things. Want to get this in the new rust release. :)

@ritchie46 ritchie46 force-pushed the fix-lititer-dtype branch from a36eabe to 5f50cc9 Compare July 15, 2023 08:18
@ritchie46 ritchie46 merged commit af85965 into pola-rs:main Jul 15, 2023
@0xbe7a 0xbe7a deleted the fix-lititer-dtype branch July 15, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 left review comments

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateTime type lost after unique() inside GroupBy Context
2 participants
@0xbe7a @ritchie46