Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust, python): fix row-encode of 32 byte payloads #9843

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jul 12, 2023

We use a block size of 32 bytes in our row-encoding. By accident we overwrote the final block if size % 32 == 0. This ensures we don't.

fixes #9837

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 12, 2023
@ritchie46 ritchie46 merged commit 83ef64f into main Jul 12, 2023
@ritchie46 ritchie46 deleted the encode branch July 12, 2023 18:42
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group_by chokes on 1000 strings
1 participant