Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python, rust): Remove stray arr.eval references #9821

Merged
merged 2 commits into from
Jul 12, 2023
Merged

chore(python, rust): Remove stray arr.eval references #9821

merged 2 commits into from
Jul 12, 2023

Conversation

avimallu
Copy link
Contributor

Just something that popped up during some work I was doing. Let me know if my tags are wrong - wasn't sure where to put them.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 11, 2023
@avimallu
Copy link
Contributor Author

Failure on Ubuntu seems unrelated: FAILED tests/unit/streaming/test_streaming.py::test_streaming_groupby_ooc - OSError: No such file or directory (os error 2). I didn't touch that code. 😅

@stinodego
Copy link
Contributor

Failure on Ubuntu seems unrelated: FAILED tests/unit/streaming/test_streaming.py::test_streaming_groupby_ooc - OSError: No such file or directory (os error 2). I didn't touch that code. 😅

Don't worry about it, it's a known issue. See #9122. I just made a PR to hopefully address it.

@avimallu avimallu changed the title fix(python, rust): Remove stray arr.eval references chore(python, rust): Remove stray arr.eval references Jul 12, 2023
@github-actions github-actions bot added the chore Maintenance work that does not impact the user label Jul 12, 2023
ritchie46
ritchie46 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ritchie46 ritchie46 merged commit 4e70557 into pola-rs:main Jul 12, 2023
@avimallu avimallu deleted the stray_arr_references branch July 12, 2023 12:19
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@avimallu @c-peters
chore(python, rust): Remove stray arr.eval references (pola-rs#9821)
70b1984
@stinodego stinodego added the internal An internal refactor or improvement label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user fix Bug fix internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avimallu @stinodego @ritchie46