Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(python,rust): More cleanup around arange #9769

Merged
merged 3 commits into from
Jul 8, 2023
Merged

refactor(python,rust): More cleanup around arange #9769

merged 3 commits into from
Jul 8, 2023

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Jul 7, 2023 •
edited
Loading

Changes:

  • Add dtype argument for int_range. Right now it's just a cast after the fact - but I will try to implement this later such that the Series gets materialized in the right data type.
  • Use int_range instead of arange internally.
  • Update arange docs with a proper deprecation message and "See Also" section.

@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality rust Related to Rust Polars labels Jul 7, 2023
@stinodego stinodego marked this pull request as ready for review July 7, 2023 15:53
MarcoGorelli
MarcoGorelli reviewed Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, rest looks good

.github/ISSUE_TEMPLATE/bug_report_python.yml Outdated Show resolved Hide resolved
MarcoGorelli
MarcoGorelli approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@stinodego stinodego merged commit a49836e into main Jul 8, 2023
@stinodego stinodego deleted the arange-cleanup branch July 8, 2023 23:38
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@stinodego @c-peters
refactor(python,rust): More cleanup around arange (pola-rs#9769)
5fff70b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
python Related to Python Polars refactor Code improvements that do not change functionality rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @MarcoGorelli