fix(rust, python): Loosen restrictions on cut expressions and add docs #9730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magarick
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
github-actions
bot
added
fix
ritchie46
reviewed
Jul 6, 2023
| // For now, we can't qcut over groups without creating consistent labels. The generated | ||
| // labels would be based on per-group quantiles, and per-group label differences caused | ||
| // problems when combining into a single categorical Series | ||
| let group_ok = labels.is_some(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with
qcutcategoricals only manifests when explicit names aren't provided and the per-group labels are inconsistent. This allowsqcutto be used in windows when labels are provided. It also removes the restriction on usingcutin windows since the breaks will always be uniform which shouldn't trigger the bug. Finally, it adds some documentation and examples for the new functionality.