-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rust,python): refactor arange
and add int_range
/int_ranges
#9666
Conversation
65d5689
to
c988140
Compare
arange
and add int_range
/int_ranges
arange
and add int_range
/int_ranges
Nice! Is the idea to introduce Just a suggestion testing-wise - perhaps it'd be good to test the schema in the lazy case, like how is done in the |
That's what I would propose. But I can imagine Ritchie might want to keep
Thanks, I'll look into it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I like that we moved the implementation properly to the new architecture.
On the naming of arange
. I think we should keep it around as an alias to int_range
. I believe the range in almost all programming language defaulted to integers. But given that we clarify the dtype
for time
and date
, I understand the specific naming need.
Sounds fair enough. Then I'll deprecate the part of |
Is |
It should be available in Rust! |
I see: |
Ah yes. The feature has been renamed from |
Adding: |
Are you sure? You should activate it on your cargo.toml. This decorator will only ensure your code is excluded from compilation until you activate that feature on your crate. |
You are correct, Adding these lines to Cargo.toml solves it, is this the best approach? Thx
|
Yes. |
Partially addresses #9019
Changes:
arange
to make use of the existing expression architectureint_range
andint_ranges
functions as alias forarange
functionality.arange
has some merit naming-wise (exists innumpy
, for example), it's not a good name. What exactly is an 'array range'? We havetime_range
,date_range
, let's be explicit and call this what it is: anint_range
. We could add afloat_range
later, for example.Future steps (not included here to keep diff somewhat small):
dtype
arg forint_range(s)
on the Rust side to avoid materializing everything asInt64
first.arange
?Can we deprecate
arange
as a whole, or do we want to keep this function due to name familiarity? If we keep it, do we want to split out functionality intoarange
/aranges
? I prefer getting rid of it entirely.