feat(python,rust): extend dtype/selector matching for Datetime with a "*" wildcard for timezones
#9641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "*" wildcard for timezones
github-actions
bot
added
enhancement
MarcoGorelli
reviewed
Jul 1, 2023
ritchie46
reviewed
Jul 1, 2023
alexander-beedie
force-pushed
the
datetime-timezone-wildcard
branch
from
33b4fb4 to
8a4b8f8
Compare
alexander-beedie
force-pushed
the
datetime-timezone-wildcard
branch
from
8a4b8f8 to
af806a0
Compare
alexander-beedie
force-pushed
the
datetime-timezone-wildcard
branch
from
57b734c to
b094d7b
Compare
ritchie46
approved these changes
Jul 2, 2023
ritchie46
reviewed
Jul 2, 2023
c-peters
pushed a commit
to c-peters/polars
that referenced
this pull request
Jul 14, 2023
… a "*" wildcard for timezones (pola-rs#9641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5300.
Allows the
pl.DATETIME_DTYPESgroup to cover all timeunit/timezone combinations.Further enhances the
cs.datetimeselector so that it can handle arbitrary permutations of timeunit/timezone, eg:cs.datetime()→ any timeunit, any (or no) timezonecs.datetime( time_zone="*" )→ any timeunit, any timezone (but must have a timezone)cs.datetime( time_zone=None )→ any timeunit, no timezonecs.datetime( ["ms","ns"], time_zone="UTC" )→ any col with UTC timezone and ns or ms precisioncs.datetime( time_zone=["UTC","Asia/Tokyo","Europe/London"] )→ any timeunit, one of the given timezones(Note: all of the expressions above could also be negated using
~).Finally adds the missing piece to the Datetime dtype selection puzzle that has been timezones... :)