feat(rust, python): add dt.dst_offset feature #9629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
MarcoGorelli
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
ritchie46
reviewed
Jun 30, 2023
polars/polars-time/src/dst_offset.rs
Outdated
| }; | ||
|
|
||
| #[cfg(feature = "timezones")] | ||
| pub trait PolarsDSTOffset { |
There was a problem hiding this comment.
Given that we only dispatch via the expression API. Shall simply make a function that accepts a &DatetimeChunked.
|
Thanks @MarcoGorelli. Looks great! I shall leave the credit of the SO question for you. ;) |
|
Whoops! I already merged. We forgot the docs entry in the reference guide. 🙈 |
|
ah my bad (I may need to try writing a script for this, it's not the first time I forget) - anyway, added in #9636 for now |
2 tasks
c-peters
pushed a commit
to c-peters/polars
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://stackoverflow.com/questions/76578147/dst-temporal-feature-from-timestamp-using-polars ;) (should probably be added as an answer if/when accepted + released)
Related, but I think it'd be good to add
.dt.base_utc_offsetas well