Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(python, rust): clean up inconsistencies in duration string language #9551

Merged
merged 6 commits into from
Jun 26, 2023
Merged

docs(python, rust): clean up inconsistencies in duration string language #9551

merged 6 commits into from
Jun 26, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Jun 25, 2023
stinodego
stinodego approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine - but what is a 'calendar week' or a 'calendar day'? How is it different from a regular week / day?

@MarcoGorelli
Copy link
Collaborator Author

I'll clarify, thanks!

@MarcoGorelli MarcoGorelli marked this pull request as draft June 25, 2023 18:37
@MarcoGorelli MarcoGorelli marked this pull request as ready for review June 26, 2023 09:25
@stinodego stinodego merged commit f8a0670 into pola-rs:main Jun 26, 2023
@stinodego
Copy link
Member

Thanks @MarcoGorelli !

c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@MarcoGorelli @c-peters
docs(python, rust): clean up inconsistencies in duration string langu…
cf17ec8 
…age (pola-rs#9551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGorelli @stinodego