Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust, python): maintain sortedness flags on append/extend #9496

Merged
merged 2 commits into from
Jun 23, 2023
Merged

fix(rust, python): maintain sortedness flags on append/extend #9496

merged 2 commits into from
Jun 23, 2023

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jun 22, 2023 •
edited
Loading

fixes #9494

Will add the other dtypes as well.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 22, 2023
@MarcoGorelli
Copy link
Collaborator

fixes #9465

is this meant to be #9494 ?

@ritchie46
Copy link
Member Author

fixes #9465

is this meant to be #9494 ?

Whoops, updated. 👍

@ritchie46 ritchie46 merged commit c670555 into main Jun 23, 2023
@ritchie46 ritchie46 deleted the flags branch June 23, 2023 07:19
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@ritchie46 @c-peters
fix(rust, python): maintain sortedness flags on append/extend (pola-r…
3dfcf83 
…s#9496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groupby_dynamic fails in streaming mode even when sorted
2 participants
@ritchie46 @MarcoGorelli