refactor(rust): Remove StdWindow in rolling #9486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
refactor
|
Nice, that cleans up a lot of code. Do we maintain the same numerical stability? |
Results are the same. |
|
Yeap, you are right, we do exactly the same. Nice.. Always good to have less code to compile. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the code by using VarWindow and taking the sqrt in place any time the rolling StdWindow would have been used. I tested the performance and it's either the same or even a little better in some cases(faster to take the sqrt of contiguous numbers all at once rather than one at at time?)