Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): remove unreachable code #9463

Merged
merged 1 commit into from
Jun 20, 2023
Merged

chore(rust): remove unreachable code #9463

merged 1 commit into from
Jun 20, 2023

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Jun 20, 2023 •
edited
Loading

rolling_* functions don't let you specify offset, but just period - so, there's more arguments than necessary in many of these internal functions, and a fair bit can be simplified / cleaned up

@github-actions github-actions bot added chore Maintenance work that does not impact the user rust Related to Rust Polars labels Jun 20, 2023
@MarcoGorelli MarcoGorelli marked this pull request as ready for review June 20, 2023 14:15
@MarcoGorelli MarcoGorelli requested a review from ritchie46 as a code owner June 20, 2023 14:15
@ritchie46
Copy link
Member

Nice!

@ritchie46 ritchie46 merged commit 12c4d9a into pola-rs:main Jun 20, 2023
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@MarcoGorelli @c-peters
chore(rust): remove unreachable code (pola-rs#9463)
a07cef1
@stinodego stinodego added the internal An internal refactor or improvement label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

Assignees
No one assigned
Labels
chore Maintenance work that does not impact the user internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @ritchie46 @stinodego