fix(rust, python): read_csv was parsing dates incorrectly when the dtype was overridden #9420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype was overridden
github-actions
bot
added
fix
MarcoGorelli
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
MarcoGorelli
commented
Jun 17, 2023
| { | ||
| let val = match value { | ||
| Value::String(s) => s, | ||
| _ => return None, | ||
| }; | ||
| infer_pattern_single(val).and_then(|pattern| { | ||
| match DatetimeInfer::<T::Native>::try_from(pattern) { | ||
| match DatetimeInfer::<T::Native>::try_from_with_unit(pattern, Some(TimeUnit::Microseconds)) |
There was a problem hiding this comment.
just preserving the status-quo here, but perhaps this could also be more precise - will take a look
ritchie46
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Looks good @MarcoGorelli. Thanks!
Can be merged when the conflicts are solved.
|
thanks for your review! ok shipping then |
c-peters
pushed a commit
to c-peters/polars
that referenced
this pull request
Jul 14, 2023
…ype was overridden (pola-rs#9420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9102
The main idea here is:
try_from(pattern), usetry_from_with_unit(pattern, unit)Then, instead of having to do
you can just do
It also means you can pass the
time_unitforwards within theslow_datetime_parserTo get the
time_unit, it needs to be an argument ofparse_bytes. I've made it of typeOption<TimeUnit>, so that when parsing non-datetime type (e.g. Utf8), thentime_unitcan be set toNone, and fordatetime, it can either be the defaultMicrosecondor whatever the user overrid it with