fix(rust): date_range with unit microseconds was producing incorrect results #9413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
date-range-micro-rust
branch
2 times, most recently
from
7584c4f to
4e46771
Compare
MarcoGorelli
force-pushed
the
date-range-micro-rust
branch
from
4e46771 to
438ea2c
Compare
MarcoGorelli
commented
Jun 17, 2023
Comment on lines
67
to
69
| TimeUnit::Nanoseconds => (start.timestamp_nanos(), stop.timestamp_nanos()), | ||
| TimeUnit::Microseconds => ( | ||
| start.timestamp() + start.timestamp_subsec_micros() as i64, | ||
| stop.timestamp() + stop.timestamp_subsec_millis() as i64, | ||
| ), | ||
| TimeUnit::Microseconds => (start.timestamp_micros(), stop.timestamp_micros()), | ||
| TimeUnit::Milliseconds => (start.timestamp_millis(), stop.timestamp_millis()), |
There was a problem hiding this comment.
the difference was introduced in https://github.com/pola-rs/polars/pull/2711/files, but I can't tell why - @ritchie46 do you happen to remember?
There was a problem hiding this comment.
No, no idea. It has been a while. :)
ritchie46
reviewed
Jun 18, 2023
Comment on lines
67
to
69
| TimeUnit::Nanoseconds => (start.timestamp_nanos(), stop.timestamp_nanos()), | ||
| TimeUnit::Microseconds => ( | ||
| start.timestamp() + start.timestamp_subsec_micros() as i64, | ||
| stop.timestamp() + stop.timestamp_subsec_millis() as i64, | ||
| ), | ||
| TimeUnit::Microseconds => (start.timestamp_micros(), stop.timestamp_micros()), | ||
| TimeUnit::Milliseconds => (start.timestamp_millis(), stop.timestamp_millis()), |
There was a problem hiding this comment.
No, no idea. It has been a while. :)
polars/polars-time/src/date_range.rs
Outdated
| @@ -110,3 +107,84 @@ pub fn time_range( | |||
| let stop = time_to_time64ns(&stop); | |||
| time_range_impl(name, start, stop, every, closed) | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
Can we move these tests to the integration tests? This will save a lot of compile times as every test module is compiled in a separate binary. In the aggregation tests we can accumulate that.
ritchie46
approved these changes
Jun 19, 2023
c-peters
pushed a commit
to c-peters/polars
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9409