Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rust): Fix some doc examples #9405

Merged
merged 3 commits into from
Jun 24, 2023
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 16, 2023

Goal is to make cargo test --all-features work from the workspace root... Running into some failing tests/doctests along the way.

@stinodego stinodego requested a review from ritchie46 as a code owner June 16, 2023 19:26
@@ -241,7 +241,7 @@
//! that you need to pass the values to an external function you do not control. The snippet below
//! shows how we use the `Struct` datatype to be able to apply a function over multiple inputs.
//!
//! ```
//! ```ignore
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know how to fix this one - ignored for now.

@stinodego stinodego marked this pull request as draft June 16, 2023 19:39
@stinodego stinodego marked this pull request as ready for review June 16, 2023 20:32
@ghost ghost force-pushed the fix-rust-tests branch from 220c244 to 7ce763c Compare June 17, 2023 02:40
@stinodego stinodego changed the title doc(rust): Fix some doc examples docs(rust): Fix some doc examples Jun 17, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation rust Related to Rust Polars labels Jun 17, 2023
@stinodego stinodego marked this pull request as draft June 23, 2023 09:40
@stinodego stinodego marked this pull request as ready for review June 24, 2023 12:05
@stinodego stinodego merged commit 38f9ec9 into pola-rs:main Jun 24, 2023
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@stinodego stinodego deleted the fix-rust-tests branch December 5, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants