Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust, python): raise more informative error on string arguments #9352

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

ritchie46
Copy link
Member

fixes #9326

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 13, 2023
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Jun 14, 2023

How about "asof join only supported on temporal keys" or, more expansive, "asof join only supported on temporal/numeric keys"? Not everyone may make the connection with temporal data having i64 backing 🤔

@ritchie46 ritchie46 merged commit fa11e48 into main Jun 14, 2023
@ritchie46 ritchie46 deleted the string branch June 14, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when collecting JoinType::AsOf
2 participants