chore(rust): simplify slow datetime parser #9183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
MarcoGorelli
changed the title
github-actions
bot
added
documentation
MarcoGorelli
added
rust
MarcoGorelli
force-pushed
the
simplify-slow-datetime-parser
branch
from
453f7a0 to
cd498a4
Compare
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
simplify-slow-datetime-parser
branch
from
cd498a4 to
2a6c551
Compare
MarcoGorelli
removed
documentation
c-peters
pushed a commit
to c-peters/polars
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drive by: simplify part of the slow datetime parser, which I'd made more complicated than necessary last time round (would normally keep them separate, but they're both very small - is this OK?)EDIT: naah, keeping that to a separate PR, easier to revert (if necessary) this way