feat(python,rust): add drop_first parameter for to_dummies (issue #8246)

[EdmundsEcho]

(Closes #8246).

The fix add the "drop_first" parameter to the to_dummies function. See issue #8246: "to_dummies implementation may be incorrect". The changes were made in-line with py/pandas. The parameter is a bool with a default value false. The default value is False; consistent with py/pandas.

I updated the current tests where applicable by including the additional parameter set to false. I did not create new tests with the parameter set to true (or True in py).

However, I did test the changes in the rust code on my local machine. The reason for not adding a new test was only because several unrelated tests were not passing And I was not familiar with the testing structure.

[avimallu]

You might need to rename the issue as feat(python,rust): add drop_first parameter for to_dummies or something similar. Right now the title isn't very descriptive.

[alexander-beedie]

Hi @EdmundsEcho! Thanks for the contribution; I've addressed the lint errors, added some test coverage and made a small fix - if you'd like to get this into our next release, I can push these updates onto your branch (here) so we can finish it off? (Though I think you'd have to allow me to do so: see the "Allow edits from maintainers" checkbox) ;)

[avimallu]

+1 on getting this to the next release, a very helpful argument to have!

[EdmundsEcho]

@alexander-beedie I had to invite you to be a writing collaborator to the project. This is a bug with github hosted under an organization (Lucivia). Let me know if you can't make the push happen. I'll see what I can do to integrate the changes.

[alexander-beedie]

I had to invite you to be a writing collaborator to the project.
Let me know if you can't make the push happen.

Great, thanks! Think this should have got it... let's see how the tests go ;)

[avimallu]

This should close #8246 and #9483, to keep track.

[alexander-beedie]

This should close #8246 and #9483, to keep track.

Thanks :)

[ritchie46]

Looks good. Thanks everybody.