Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(python, rust): change decimal inference and argument order #9133

Merged
merged 1 commit into from
May 31, 2023
Merged

refactor(python, rust): change decimal inference and argument order #9133

merged 1 commit into from
May 31, 2023

Conversation

ritchie46
Copy link
Member

This breaks the Decimal datatype constructor on the python side. But we clearly state decimal to be in alpha, so users should expect these changes.

@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality rust Related to Rust Polars labels May 31, 2023
@ritchie46 ritchie46 enabled auto-merge (squash) May 31, 2023 09:07
@ritchie46 ritchie46 disabled auto-merge May 31, 2023 09:07
@ritchie46 ritchie46 merged commit 773385f into main May 31, 2023
@ritchie46 ritchie46 deleted the dec branch May 31, 2023 09:07
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@ritchie46 @c-peters
refactor(python, rust): change decimal inference and argument order (p…
09fc32a 
…ola-rs#9133)
@alexander-beedie alexander-beedie added the A-dtype-decimal Area: decimal data type label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
A-dtype-decimal Area: decimal data type python Related to Python Polars refactor Code improvements that do not change functionality rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @alexander-beedie