Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): json_extract on empty series #9126

Merged
merged 1 commit into from
May 31, 2023
Merged

fix(rust): json_extract on empty series #9126

merged 1 commit into from
May 31, 2023

Conversation

josh
Copy link
Contributor

@josh josh commented May 30, 2023

Regression from #8858 (which looks pretty nice btw). Fixes empty series parsing by ensuring the opening [ isn't popped off.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels May 30, 2023
@ritchie46
Copy link
Member

Thank you!

@ritchie46 ritchie46 merged commit 777efb6 into pola-rs:main May 31, 2023
@josh josh deleted the fix_json_extract_empty branch May 31, 2023 14:51
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
@josh @c-peters
fix(rust): json_extract on empty series (pola-rs#9126)
2d06f37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh @ritchie46