Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(python,rust): Use faster compression backend for parquet #4262

Closed
wants to merge 1 commit into from

Conversation

ritchie46
Copy link
Member

This uses zlib-ng and lz4_flex as backend in favor of the defaults. #4259

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Aug 4, 2022
@ritchie46 ritchie46 force-pushed the faster_parquet_compression branch from a3f22a5 to 528a0da Compare August 4, 2022 19:02
@ritchie46
Copy link
Member Author

Tests fail, so have to investigate later.

@codecov-commenter
Copy link

Codecov Report

Merging #4262 (528a0da) into master (d1e5b10) will increase coverage by 0.64%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
+ Coverage   64.05%   64.70%   +0.64%     
==========================================
  Files         462      460       -2     
  Lines       76112    75314     -798     
==========================================
- Hits        48757    48734      -23     
+ Misses      27355    26580     -775     
Impacted Files Coverage Δ
polars/polars-core/src/vector_hasher.rs 74.19% <0.00%> (ø)
polars/polars-lazy/src/frame/parquet.rs 53.48% <0.00%> (-11.63%) ⬇️
...s/polars-core/src/series/implementations/floats.rs 59.50% <0.00%> (-0.93%) ⬇️
py-polars/src/dataframe.rs 88.67% <0.00%> (-0.80%) ⬇️
polars/polars-core/src/fmt.rs 45.60% <0.00%> (-0.74%) ⬇️
...rs-lazy/src/logical_plan/optimizer/file_caching.rs 95.28% <0.00%> (-0.59%) ⬇️
...olars/polars-core/src/frame/groupby/into_groups.rs 59.58% <0.00%> (-0.30%) ⬇️
...lars/polars-core/src/chunked_array/builder/list.rs 62.29% <0.00%> (-0.28%) ⬇️
polars/polars-io/src/csv/buffer.rs 79.55% <0.00%> (-0.25%) ⬇️
py-polars/polars/internals/frame.py 91.37% <0.00%> (-0.21%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghuls
Copy link
Collaborator

ghuls commented Sep 9, 2022

Keep in mind that there are alsos some kind of regression in zlib-ng related to gzipped CSV files (or at least with the rust binding).
rust-lang/libz-sys#104

@stinodego stinodego changed the title use faster compression backend for parquet perf(python,rust): Use faster compression backend for parquet Oct 1, 2022
@github-actions github-actions bot added the performance Performance issues or improvements label Oct 1, 2022
@ritchie46 ritchie46 closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants