Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rolling groupby with negative windows #4010

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

ritchie46
Copy link
Member

fixes #4002

@github-actions github-actions bot added python Related to Python Polars rust Related to Rust Polars labels Jul 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4010 (20c5fb3) into master (f794a07) will decrease coverage by 0.00%.
The diff coverage is 70.73%.

@@            Coverage Diff             @@
##           master    #4010      +/-   ##
==========================================
- Coverage   62.62%   62.61%   -0.01%     
==========================================
  Files         447      447              
  Lines       73971    74035      +64     
==========================================
+ Hits        46322    46358      +36     
- Misses      27649    27677      +28     
Impacted Files Coverage Δ
polars/polars-time/src/groupby/dynamic.rs 46.11% <0.00%> (-1.87%) ⬇️
polars/polars-time/src/windows/groupby.rs 77.84% <95.08%> (+1.89%) ⬆️
...s/polars-core/src/chunked_array/ops/take/traits.rs 51.61% <0.00%> (-5.38%) ⬇️
...s/polars-core/src/series/implementations/floats.rs 59.13% <0.00%> (-0.93%) ⬇️
polars/polars-core/src/chunked_array/cast.rs 72.22% <0.00%> (-0.70%) ⬇️
polars/polars-core/src/utils/mod.rs 52.23% <0.00%> (-0.36%) ⬇️
...olars/polars-core/src/frame/groupby/into_groups.rs 55.52% <0.00%> (-0.30%) ⬇️
polars/polars-core/src/datatypes/mod.rs 49.90% <0.00%> (-0.19%) ⬇️
polars/polars-core/src/fmt.rs 44.58% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f794a07...20c5fb3. Read the comment docs.

@ritchie46 ritchie46 merged commit 4ee4f7c into master Jul 13, 2022
@ritchie46 ritchie46 deleted the rolling_groupby branch July 13, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

groupby_rolling yields incorrect windows if window ends before reference date
2 participants