Fix Pandas date_range warnings in tests #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Pandas 1.4 (released Jan 2022), the input arg `closed` for pd.date_range has been deprecated in favor of `inclusive` (https://pandas.pydata.org/docs/reference/api/pandas.date_range.html) This generated two warnings in our Python test suite. In one of the two cases, we just needed a range of dates, so switched that to polars.date_range, for the other use case updated the keyword.
zundertj
commented
Jul 8, 2022
| @@ -1449,7 +1451,8 @@ def test_join_dates() -> None: | |||
| "value": [2, 3, 4, 1, 2, 3, 5, 1, 2, 3], | |||
| } | |||
| ) | |||
| df.join(df, on="datetime") | |||
| out = df.join(df, on="datetime") | |||
| assert len(out) == len(df) | |||
There was a problem hiding this comment.
Added a basic assertion here, there was no assert in place.
|
Thanks you @zundertj. Do you know about the reason of the change? |
|
Consistency of the API: pandas-dev/pandas#40245. Although I do not see any deep thinking on why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Pandas 1.4 (released Jan 2022), the input arg
closedforpd.date_rangehas been deprecated in favor ofinclusive(https://pandas.pydata.org/docs/reference/api/pandas.date_range.html). This generated two warnings in our Python test suite. In one of the two cases, we just needed a range of dates, so switched that topolars.date_range, for the other use case updated the keyword. This does mean one needs Pandas >= 1.4 for running the test suite.