Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove todo and test restriction for new-streaming #20861

Merged
merged 1 commit into from
Jan 23, 2025
Merged

chore: Remove todo and test restriction for new-streaming #20861

merged 1 commit into from
Jan 23, 2025

Conversation

etiennebacher
Copy link
Contributor

Fixes #20440

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 23, 2025
@etiennebacher etiennebacher marked this pull request as ready for review January 23, 2025 09:51
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (24fccc4) to head (69328e3).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20861      +/-   ##
==========================================
- Coverage   79.64%   79.64%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      223156   223165       +9     
  Branches     2546     2546              
==========================================
+ Hits       177731   177734       +3     
- Misses      44841    44847       +6     
  Partials      584      584

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 79eedcf into pola-rs:main Jan 23, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New streaming engine incorrectly sets sorted flag for lexical categorical in partition_by
2 participants
@etiennebacher @ritchie46