Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(python): Update ML part of ecosystem user guide page #20596

Merged
merged 10 commits into from
Jan 16, 2025
Merged

docs(python): Update ML part of ecosystem user guide page #20596

merged 10 commits into from
Jan 16, 2025

Conversation

braaannigan
Copy link
Collaborator

Add additional info about working with ML packages with Polars

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Jan 7, 2025
rodrigogiraoserrao
rodrigogiraoserrao requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filling this.
I have a couple of minor requests and then a couple of comments for your consideration.

docs/source/user-guide/ecosystem.md Outdated Show resolved Hide resolved
docs/source/user-guide/ecosystem.md Outdated Show resolved Hide resolved
docs/source/user-guide/ecosystem.md Outdated Show resolved Hide resolved
docs/source/user-guide/ecosystem.md Outdated Show resolved Hide resolved
docs/source/user-guide/ecosystem.md Outdated Show resolved Hide resolved
docs/source/user-guide/ecosystem.md Show resolved Hide resolved
docs/source/user-guide/ecosystem.md Outdated Show resolved Hide resolved
@braaannigan
Copy link
Collaborator Author

@rodrigogiraoserrao Ready for you

@braaannigan
Copy link
Collaborator Author

@rodrigogiraoserrao
Actually - there's an issue, I'm looking into it

rodrigogiraoserrao
rodrigogiraoserrao requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing to fix 😬

docs/source/user-guide/ecosystem.md Outdated Show resolved Hide resolved
rodrigogiraoserrao
rodrigogiraoserrao approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :D

@ritchie46 ritchie46 merged commit e4cde03 into pola-rs:main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@braaannigan @rodrigogiraoserrao @ritchie46