Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Add include_file_paths parameter to read_parquet #19008

Conversation

LukasFolwarczny
Copy link
Contributor

Closes #18962.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Sep 29, 2024
Copy link
Collaborator

@coastalwhite coastalwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (d0963db) to head (6c8bdf6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/io/parquet/functions.py 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19008      +/-   ##
==========================================
- Coverage   79.89%   79.86%   -0.03%     
==========================================
  Files        1524     1524              
  Lines      207655   207658       +3     
  Branches     2904     2905       +1     
==========================================
- Hits       165898   165855      -43     
- Misses      41210    41255      +45     
- Partials      547      548       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukasFolwarczny LukasFolwarczny marked this pull request as ready for review September 29, 2024 15:11
@ritchie46 ritchie46 merged commit 4985576 into pola-rs:main Sep 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add include_file_paths parameter to read_parquet
3 participants