Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Refactor ArrowSchema to use polars_schema::Schema<D> #18564

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Sep 5, 2024

  • There is a lot of functionality that works with &[Field], which no longer interops nicely after we change ArrowSchema's repr from Vec<Field> to PlIndexMap<..>, so I've changed them to accept &ArrowSchema instead.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 82.57261% with 42 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (e4746a5) to head (d6d9609).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/io/ipc/read/file_async.rs 0.00% 12 Missing ⚠️
crates/polars-schema/src/schema.rs 84.78% 7 Missing ⚠️
...rates/polars-arrow/src/io/ipc/read/stream_async.rs 0.00% 5 Missing ⚠️
...es/polars-parquet/src/arrow/read/schema/convert.rs 80.00% 3 Missing ⚠️
crates/polars-stream/src/nodes/parquet_source.rs 0.00% 3 Missing ⚠️
crates/polars-core/src/schema.rs 85.71% 2 Missing ⚠️
crates/polars-io/src/utils/other.rs 66.66% 2 Missing ⚠️
crates/polars-parquet/src/arrow/write/sink.rs 0.00% 2 Missing ⚠️
crates/polars-arrow/src/io/ipc/write/file_async.rs 0.00% 1 Missing ⚠️
...ates/polars-arrow/src/io/ipc/write/stream_async.rs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18564      +/-   ##
==========================================
- Coverage   79.82%   79.82%   -0.01%     
==========================================
  Files        1502     1501       -1     
  Lines      201933   201949      +16     
  Branches     2868     2868              
==========================================
+ Hits       161201   161205       +4     
- Misses      40186    40198      +12     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review September 5, 2024 09:44
@ritchie46 ritchie46 merged commit 10fab78 into pola-rs:main Sep 5, 2024
22 checks passed
@ritchie46
Copy link
Member

Super happy with this one!

@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
@nameexhaustion nameexhaustion deleted the polars-schema-arrow branch September 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants