Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Remove top-level metadata from ArrowSchema #18527

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Preparation for unifying schemas to struct Schema<D>

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (f5edd91) to head (3840ba3).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/io/ipc/read/file_async.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18527      +/-   ##
==========================================
- Coverage   79.85%   79.84%   -0.02%     
==========================================
  Files        1501     1501              
  Lines      201865   201823      -42     
  Branches     2868     2868              
==========================================
- Hits       161202   161144      -58     
- Misses      40117    40133      +16     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review September 3, 2024 08:24
@ritchie46 ritchie46 merged commit 04d0978 into pola-rs:main Sep 3, 2024
21 checks passed
@nameexhaustion nameexhaustion deleted the arrow-top-md branch September 4, 2024 05:40
@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
@lukapeschke
Copy link
Contributor

Hi, I have a question about this change: we're currently using polars v0.41.3, and use polars_arrow::ipc::write::stream_async::StreamSink to serialize our dataframes to arrow IPC data. We were using ArrowSchema::with_metadata to add custom applicative metadata at the schema level.

Is it still possible to add schema-level metadata with polars v0.43 ? If yes, could you please point me to the right resources ? Thanks!

@nameexhaustion
Copy link
Collaborator Author

Is it still possible to add schema-level metadata with polars v0.43 ? If yes, could you please point me to the right resources ? Thanks!

We don't intend on adding schema-level metadata to the ArrowSchema, however we plan to add functions to the reader / writers to load / save custom metadata.

@lukapeschke
Copy link
Contributor

@nameexhaustion great thanks! Do you have a specific polars release for which this is planned ? If not, could I help on that in any way ?

@nameexhaustion
Copy link
Collaborator Author

@nameexhaustion great thanks! Do you have a specific polars release for which this is planned ? If not, could I help on that in any way ?

There's an open issue for this at #17560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants