Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove ecosystem viz section since there is one in misc already #18408

Merged
merged 3 commits into from
Oct 20, 2024

Conversation

joelostblom
Copy link
Contributor

@joelostblom joelostblom commented Aug 27, 2024

It seems redundant to have this in two places and it is elaborated on more in the https://docs.pola.rs/user-guide/misc/visualization/ section Instead of removing, if it is believed that this section is linked to from many external places, the heading could remain but just have a link/redirect to the Misc part of the docs. I'm not sure if pip install polars[plot] should be added to the Misc section, or if there is already a helpful error message when attempting to plot without it that is sufficient.

cc @MarcoGorelli since you recently updated the visualization misc section and added the new altair functionality in #17995

It seems redundant to have this in two places.
If this section is linked to from many external places
the section could remain but just have a link to the Misc
part of the docs.
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Aug 27, 2024
@ritchie46
Copy link
Member

Any opinion here @MarcoGorelli?

@MarcoGorelli
Copy link
Collaborator

thanks for the ping - sorry i'd missed the first one somehow

Instead of removing, if it is believed that this section is linked to from many external places, the heading could remain but just have a link/redirect to the Misc part of the docs.

Yeah I think this would be a good idea 👍 (i'm actually just in the process of updating that page 📈 )

@joelostblom
Copy link
Contributor Author

Updated accordingly!

Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @joelostblom !

@ritchie46 ritchie46 merged commit 463ed66 into pola-rs:main Oct 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants