fix(python): Handle DB cursor descriptions that contain more fields than the DBAPI2 standard #17468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17468 +/- ##
=======================================
Coverage 80.46% 80.47%
=======================================
Files 1483 1483
Lines 194856 194856
Branches 2771 2771
=======================================
+ Hits 156796 156812 +16
+ Misses 37550 37534 -16
Partials 510 510 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jul 7, 2024
| @@ -203,7 +203,7 @@ def _infer_dtype_from_cursor_description( | |||
| description: tuple[Any, ...], | |||
| ) -> PolarsDataType | None: | |||
| """Attempt to infer Polars dtype from database cursor description `type_code`.""" | |||
| type_code, _disp_size, internal_size, precision, scale, _null_ok = description | |||
| type_code, _disp_size, internal_size, precision, scale, *_ = description | |||
There was a problem hiding this comment.
TIL. Does that unpack the remainder?
There was a problem hiding this comment.
Yup; the _ will subsequently contain a sequence of "everything else" ;)
a, b, *c = [1,2,3,4,5,6,7,8,9]a
# 1
b
# 2
c
# [3, 4, 5, 6, 7, 8, 9]
|
Thank you folks, great work! Proud to be a polars user!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17466.
Not all drivers adhere to the DBAPI2 standard1 for the cursor description; the standard specifies exactly 7 attributes, but MariaDB's native driver (and possibly others, though no reports of such yet) returns more.
Trivial fix to handle the additional params.
Footnotes
https://peps.python.org/pep-0249/#cursor-attributes ↩